Fix #1476: Add support for exclusive pattern matches. #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomprince
commented
Jan 26, 2017
| @@ -14,7 +14,6 @@ | |||
| #![allow(indexing_slicing, shadow_reuse, unknown_lints, missing_docs_in_private_items)] | |||
| #![allow(needless_lifetimes)] | |||
|
|
|||
| #[macro_use] | |||
There was a problem hiding this comment.
This is unrelated but is causing test failures.
|
The build failure also occurs on master. |
oli-obk
suggested changes
Jan 27, 2017
| @@ -361,7 +361,7 @@ fn all_ranges(cx: &LateContext, arms: &[Arm]) -> Vec<SpannedRange<ConstVal>> { | |||
| } | |||
| .filter_map(|pat| { | |||
| if_let_chain! {[ | |||
| let PatKind::Range(ref lhs, ref rhs) = pat.node, | |||
| let PatKind::Range(ref lhs, ref rhs, _) = pat.node, | |||
There was a problem hiding this comment.
I don't think that's quite right. The SpannedRange returned below is different depending on the inclusiveness
|
I'll publish a release, we can fix any exclusive pattern issues later (they are unstable anyway), at least clippy will compile again |
|
I've pushed what I think is a fix for the false positive introduced here in #1479. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there that should be updated for this change.