Skip to content

fix: option_if_let_else suggests wrongly when coercion requires explicit cast #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: option_if_let_else suggests wrongly when coercion requires explicit cast #14389

merged 1 commit into from
Mar 26, 2025

Conversation

profetia
Copy link
Contributor

Closes #11059

changelog: option_if_let_else: fix wrong suggestion when coersion requires explicit cast

@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 11, 2025
@profetia profetia force-pushed the issue11059 branch 4 times, most recently from 471dc4e to 10627b4 Compare March 17, 2025 14:18
samueltardieu
samueltardieu reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: there is also a typo "coersion → coercion" in the PR title and in the commit message

@profetia profetia force-pushed the issue11059 branch 3 times, most recently from 2950294 to d118a19 Compare March 17, 2025 14:33
@profetia profetia changed the title fix: option_if_let_else suggests wrongly when coersion requires explicit cast fix: option_if_let_else suggests wrongly when coercion requires explicit cast Mar 21, 2025
@profetia profetia force-pushed the issue11059 branch 2 times, most recently from e3a45e1 to db5fc31 Compare March 21, 2025 05:30
@samueltardieu samueltardieu added the L-nursery Lint: Currently in the nursery group label Mar 21, 2025
dswij
dswij approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dswij dswij added this pull request to the merge queue Mar 26, 2025
Merged via the queue into rust-lang:master with commit 939d5f9 Mar 26, 2025
11 checks passed
@profetia profetia mentioned this pull request Mar 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@Alexendoo Alexendoo Alexendoo left review comments

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
L-nursery Lint: Currently in the nursery group S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy::option_if_let_else suggests invalid code fix
5 participants
@profetia @rustbot @samueltardieu @Alexendoo @dswij