Don't use LateContext in the constant evaluator
#13200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
constant_no_typeck
branch
2 times, most recently
from
1d5b9b9 to
3474d6a
Compare
Jarcho
force-pushed
the
constant_no_typeck
branch
from
3474d6a to
59a1ff9
Compare
|
☔ The latest upstream changes (presumably #11441) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
reviewed
Aug 8, 2024
clippy_utils/src/consts.rs
Outdated
| && let ["core", "num", int_impl, "max_value"] = *def_path | ||
| && let ExprKind::Path(qpath @ QPath::TypeRelative(_, name)) = &callee.kind | ||
| && let Res::Def(DefKind::AssocFn, did) = self.typeck.qpath_res(qpath, callee.hir_id) | ||
| && name.ident.as_str() == "max_value" |
There was a problem hiding this comment.
Just one nit I can see: since we're checking the diagnostic name we don't need the by str one
Jarcho
force-pushed
the
constant_no_typeck
branch
from
59a1ff9 to
5114d37
Compare
Jarcho
force-pushed
the
constant_no_typeck
branch
from
5114d37 to
e4ad36d
Compare
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the interface to require explicitly creating the context.
constantcould be added back in, but the others are probably not worth it.A couple of bugs have been fixed. The wrong
TypeckResultswas used once when evaluating a constant, and the wrongParamEnvwas used by some callers (there wasn't a way to use the correct one).changelog: none