Skip to content

Bump ui_test to 0.22 #12198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Bump ui_test to 0.22 #12198

merged 1 commit into from
Feb 17, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 25, 2024

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2024

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 25, 2024
@Manishearth
Copy link
Member

r=me but tests fail

@bors
Copy link
Contributor

bors commented Jan 26, 2024

☔ The latest upstream changes (presumably #12202) made this pull request unmergeable. Please resolve the merge conflicts.

@@ -1,5 +1,5 @@
error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
--> $DIR/absurd-extreme-comparisons.rs:14:5
--> tests/ui/absurd-extreme-comparisons.rs:14:5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes look like they will cause trouble in the Rust repo. 🤔 I haven't tested that yet, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work fine there as cargo test sets the working directory to the root of the package containing the tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it so it doesn't show the tests/ui part, but it still shows the subdirectories within that

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 16, 2024

and now with the 0.22.1 release, the proc macro changes are not needed anymore

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 17, 2024

📌 Commit c975c5f has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 17, 2024

⌛ Testing commit c975c5f with merge ab8880b...

@bors
Copy link
Contributor

bors commented Feb 17, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing ab8880b to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants