-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bump ui_test to 0.22 #12198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ui_test to 0.22 #12198
Conversation
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
r=me but tests fail |
☔ The latest upstream changes (presumably #12202) made this pull request unmergeable. Please resolve the merge conflicts. |
@@ -1,5 +1,5 @@ | |||
error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false | |||
--> $DIR/absurd-extreme-comparisons.rs:14:5 | |||
--> tests/ui/absurd-extreme-comparisons.rs:14:5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look like they will cause trouble in the Rust repo. 🤔 I haven't tested that yet, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work fine there as cargo test
sets the working directory to the root of the package containing the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it so it doesn't show the tests/ui part, but it still shows the subdirectories within that
f862328
to
af2dcee
Compare
af2dcee
to
c975c5f
Compare
and now with the 0.22.1 release, the proc macro changes are not needed anymore |
@bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: none