Skip to content

Lint flatten() under lines_filter_map_ok #11691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2023
Merged

Lint flatten() under lines_filter_map_ok #11691

merged 5 commits into from
Nov 19, 2023

Conversation

sjwang05
Copy link
Contributor

Fixes #11686

changelog: [lines_filter_map_ok]: Also lint calls to flatten()

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 20, 2023
@bors
Copy link
Contributor

bors commented Oct 21, 2023

☔ The latest upstream changes (presumably #11694) made this pull request unmergeable. Please resolve the merge conflicts.

@sjwang05 sjwang05 force-pushed the lines-filter-map-ok-fix branch from f5d88e0 to 05ebde1 Compare October 21, 2023 19:30
Centri3
Centri3 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 nits, thank you!

@bors
Copy link
Contributor

bors commented Nov 2, 2023

☔ The latest upstream changes (presumably #11747) made this pull request unmergeable. Please resolve the merge conflicts.

@sjwang05 sjwang05 force-pushed the lines-filter-map-ok-fix branch from e84072c to 56c6a8b Compare November 3, 2023 01:40
@sjwang05 sjwang05 force-pushed the lines-filter-map-ok-fix branch from 56c6a8b to 10f3977 Compare November 3, 2023 01:43
sjwang05 and others added 2 commits November 3, 2023 10:32
@sjwang05 @Centri3
Use fm_method_str in lint formatting
c50af35 
Co-authored-by: Catherine Flores <catherine.3.flores@gmail.com>
@sjwang05
Fix formatting
4388158
@Centri3
Copy link
Member

Centri3 commented Nov 19, 2023

Thanks, @bors r+

@bors
Copy link
Contributor

bors commented Nov 19, 2023

📌 Commit 4388158 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 19, 2023

⌛ Testing commit 4388158 with merge dbd19f9...

@bors
Copy link
Contributor

bors commented Nov 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing dbd19f9 to master...

@bors bors merged commit dbd19f9 into rust-lang:master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Centri3 approved these changes

Assignees

@Centri3 Centri3

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lines_filter_map_ok should also warn for flatten
4 participants
@sjwang05 @rustbot @bors @Centri3