[question_mark]: don't lint inside of try block

[y21]

Fixes #8628.

Diff looks a bit noisy because I had to move the two functions into an impl, because they now need to access the structs try_block_depth field to see if they're inside a try block.

changelog: [question_mark]: don't lint inside of try block

[rustbot]

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

[Jarcho]

Well that diff was useless. Nowhere near the most useless I've seen.

This doesn't handle nested functions (e.g. fn f() { try { fn f2() {} }). You'll have to keep a stack of try block depths for this.

[y21]

Well that diff was useless. Nowhere near the most useless I've seen.

Yeah, with hindsight maybe it would've been better to split it up into two commits (the relevant stuff that changed in the first commit and just passing the try depth as a param, and in the second commit moving the function into the impl). Would've probably made the relevant diff way easier to read in the first commit

This doesn't handle nested functions (e.g. fn f() { try { fn f2() {} }). You'll have to keep a stack of try block depths for this.

Fixed this in the last commit

[Jarcho]

Thank you. @bors r+

[bors]

📌 Commit 70610c0 has been approved by Jarcho

It is now in the queue for this repository.

[bors]

⌛ Testing commit 70610c0 with merge 10ce1a6...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 10ce1a6 to master...