wrong: warning: unneeded return statement
#13457
Labels
C-bug
Category: Clippy is not doing the correct thing
Comments
eareimu
added a commit
to genmeta/gm-quic
that referenced
this issue
Oct 16, 2024
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this issue
Oct 18, 2024
Don't warn on proc macro generated code in `needless_return` Fixes rust-lang#13458 Fixes rust-lang#13457 Fixes rust-lang#13467 Fixes rust-lang#13479 Fixes rust-lang#13481 Fixes rust-lang#13526 Fixes rust-lang#13486 The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does* fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`. The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context. "Hide whitespace" helps a bit for reviewing the proc macro detection change changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Wrong message
Reproducer
While im writing the document for https://github.com/genmeta/gm-quic/blob/main/qbase/src/util/future.rs#L206, the clippy reporeted a wrong message.
I expected to see this happen:
No warn.
Instead, this happened:
Version
rustc 1.83.0-nightly (9e394f551 2024-09-25)
binary: rustc
commit-hash: 9e394f551c050ff03c6fc57f190e0761cf0be6e8
commit-date: 2024-09-25
host: aarch64-apple-darwin
release: 1.83.0-nightly
LLVM version: 19.1.0
Additional Labels
No response
The text was updated successfully, but these errors were encountered: