fix: Improve asm support #19801
Merged
fix: Improve asm support #19801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including:
- Infer `label {}` and `const` operands.
- Correctly handle unsafe check inside `label {}`.
- Fix an embarrassing parser typo that cause labels to never be part of the AST
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including:
label {}andconstoperands.label {}.Our story began when I saw, in the release notes for Rust 1.87, that
label {}in inline assembly was stabilized, and recalled that I read that the lang team decided thatlabel {}blocks will start a new safety scope. Quick glance at the reference, yep that rule is there. Trying to check whether we comply to it in r-a, no we don't. Fixing is simple - unless, as it turns out, we don't supportlabelalmost at all (+const), including a very funny parser typo.