internal: ensure a Salsa-ified crate graph works with project discovery #19523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
force-pushed
the
davidbarsky/fix-salsafied-crate-graph-with-lazy-project-discovery
branch
from
7ebdcc6 to
db04fa1
Compare
Veykril
approved these changes
Apr 4, 2025
davidbarsky
force-pushed
the
davidbarsky/fix-salsafied-crate-graph-with-lazy-project-discovery
branch
from
db04fa1 to
698f4da
Compare
davidbarsky
force-pushed
the
davidbarsky/fix-salsafied-crate-graph-with-lazy-project-discovery
branch
from
698f4da to
9aa99ee
Compare
davidbarsky
deleted the
davidbarsky/fix-salsafied-crate-graph-with-lazy-project-discovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19489.
The main part of this this change is going from a
self.proc_macro_clients.is_empty()check to aself.proc_macro_clients.len() < self.workspaces.len(). I also rewrote some iterator combinators in favor of twoforloops and twomatchstatements because I had difficulty understanding the code.