fix: Handle multiple #[repr(..)] attrs correctly
#19416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Mar 22, 2025
| *int = other.int; | ||
| } | ||
| } | ||
|
|
||
| fn parse_repr_tt(tt: &crate::tt::TopSubtree) -> Option<ReprOptions> { |
There was a problem hiding this comment.
Diffs inside this function are not necessary but I think that using the above fn merge_repr would be better in consistency.
ShoyuVanilla
commented
Mar 22, 2025
| @@ -24,9 +24,6 @@ extern crate rustc_hashes; | |||
| #[cfg(not(feature = "in-rust-tree"))] | |||
| extern crate ra_ap_rustc_abi as rustc_abi; | |||
|
|
|||
| #[cfg(not(feature = "in-rust-tree"))] | |||
| extern crate ra_ap_rustc_hashes as rustc_hashes; | |||
|
|
|||
There was a problem hiding this comment.
We've been using this for rustc_hashes::Hash64::ZERO but it is replaced with Default::default() in this PR
Veykril
approved these changes
Mar 22, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15037
In codes like the following cases:
we've been using only the first
#[repr(X)]attribute on struct, but we should handle them like#[repr(X, Y, Z)]