Skip to content

fix: Honor cfg attributes on params when lowering their patterns #13380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 10, 2022

Closes #13375

@Veykril
Copy link
Member Author

Veykril commented Oct 10, 2022

Gonna test if bors is able to merge without approval (I'd expect it not to)
@bors r+

@bors
Copy link
Contributor

bors commented Oct 10, 2022

📌 Commit 63ed71b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 10, 2022

⌛ Testing commit 63ed71b with merge 8bd1114...

bors added a commit that referenced this pull request Oct 10, 2022
Honor cfg attributes on params when lowering their patterns

Closes #13375
@bors
Copy link
Contributor

bors commented Oct 10, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8bd1114 to master...

@bors
Copy link
Contributor

bors commented Oct 10, 2022

👀 Test was successful, but fast-forwarding failed: 422 At least 1 approving review is required by reviewers with write access.

@lnicola
Copy link
Member

lnicola commented Oct 10, 2022

@bors r=Veykril

Like this?

@bors
Copy link
Contributor

bors commented Oct 10, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Oct 10, 2022

📌 Commit 63ed71b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 10, 2022

⌛ Testing commit 63ed71b with merge deddad3...

@bors
Copy link
Contributor

bors commented Oct 10, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing deddad3 to master...

@bors bors merged commit deddad3 into rust-lang:master Oct 10, 2022
@Veykril
Copy link
Member Author

Veykril commented Oct 10, 2022

@bors r=Veykril

Like this?

The repo still had (github) approval reviews enabled as a requirement so bors failed. t-infra removed that again now though, since bors is already our approval (and now I can fortunately self-approve again)

@Veykril Veykril deleted the cfg-pat-params branch October 10, 2022 14:08
@lnicola lnicola changed the title Honor cfg attributes on params when lowering their patterns fix: Honor cfg attributes on params when lowering their patterns Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using feature-enabled fn parameters causes RA to emit type-mismatch for code that compiles
3 participants