-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: Honor cfg attributes on params when lowering their patterns #13380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gonna test if bors is able to merge without approval (I'd expect it not to) |
Honor cfg attributes on params when lowering their patterns Closes #13375
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 At least 1 approving review is required by reviewers with write access. |
@bors r=Veykril Like this? |
💡 This pull request was already approved, no need to approve it again.
|
☀️ Test successful - checks-actions |
The repo still had (github) approval reviews enabled as a requirement so bors failed. t-infra removed that again now though, since bors is already our approval (and now I can fortunately self-approve again) |
Closes #13375