-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Don't write logs to the dir at cwd by default #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe if the envvar is set, it could name a directory into which logs are written? |
That would be a possible extension, yeah, but I'd just start with a simple "is var equal to |
The cwd is not always clear. For example, the vscode language client seems to be |
On my Windows machine, the cwd is |
I suppose cwd also depends on whether you launch code from the command line (with TL;DR cwd of a GUI program is messy, and it seems the cwd of the language server inherits that. |
284: By default, log only to stderr, and not to disk. r=matklad a=eminence This fixes a common problem when running under VS Code, the user doesn't have permissions to create a `log` directory in the CWD. The old behavior can be re-enabled by setting `RA_INTERNAL_MODE=1` Fixes #282 Co-authored-by: Andrew Chin <achin@eminence32.net>
This writes the logs to the dir at cwd unconditionally. This is useful for development, but can trip new users if the cwd is not writable for some reasons.
Let's add an
RA_INTERNAL_MODE
env var to control logging behavior. By default we log only to stderr, but with this var set we revert to the current behavior.The text was updated successfully, but these errors were encountered: