-
Notifications
You must be signed in to change notification settings - Fork 1.7k
VSCode Test Explorer - unit test execution is slow/problematic because they run at the workspace level not crate #17470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-test-explorer
Issues related to the test explorer lsp extension and vscode test api
C-bug
Category: bug
Comments
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jun 21, 2024
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jul 22, 2024
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jul 27, 2024
…he package manifest path
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jul 27, 2024
…plorer command line
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jul 28, 2024
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jul 28, 2024
…he package manifest path
duncanawoods
pushed a commit
to duncanawoods/rust-analyzer
that referenced
this issue
Jul 28, 2024
…plorer command line
lnicola
pushed a commit
to lnicola/rust
that referenced
this issue
Jul 28, 2024
rust-lang#17470 - run unit tests at the crate level not workspace For rust-lang/rust-analyzer#17470 Use the test path to identify a package in the workspace and run the unit test there instead of at the workspace.
Fixed in #17472. |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this issue
Aug 1, 2024
rust-lang#17470 - run unit tests at the crate level not workspace For rust-lang/rust-analyzer#17470 Use the test path to identify a package in the workspace and run the unit test there instead of at the workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-test-explorer
Issues related to the test explorer lsp extension and vscode test api
C-bug
Category: bug
Invoking a single unit test from the Test Explorer or keyboard shortcut will build the entire workspace and tests are processed in every workspace member which causes several problems:
mod tests :: test_arg_parsing
cargo test
completes in millisecondsExample test output trying to execute one unit test where rust-anlayzer tries to run a test in every single workspace member which I have anonymised as
<crate>
:@HKalbasi I can see this relates to your changes here:
#17056
I have a PR that behaves as I expect which is to run tests on the crate in which they are defined and not at the workspace root but I don't know if this will cause other issues.
The text was updated successfully, but these errors were encountered: