Ensure [[:blank:]] only matches [ \t]
#534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
changed the title
[[:blank:]] only matches [ \t]. Fix #533.[[:blank:]] only matches [ \t]
BurntSushi
requested changes
Oct 29, 2018
| @@ -1040,7 +1040,7 @@ fn ascii_class(kind: &ast::ClassAsciiKind) -> &'static [(char, char)] { | |||
| X | |||
| } | |||
| Blank => { | |||
| const X: T = &[(' ', '\t')]; | |||
| const X: T = &[('\t', '\t'), (' ', ' ')]; | |||
There was a problem hiding this comment.
Oof. Thanks for catching this! It looks like a bad transcription error. However, I don't think this is right either. The docs include more characters:
[[:space:]] whitespace ([\t\n\v\f\r ])
And this is consistent with how regex-syntax 0.4 and below behaved:
regex/regex-syntax/src/parser.rs
Lines 1453 to 1454 in fa5cf6b
There was a problem hiding this comment.
@BurntSushi You're referring to docs for space, but this bug and fix are for blank which has fewer characters.
There was a problem hiding this comment.
Ug. Thanks for that. I don't think I had quite woken up yet!
BurntSushi
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Thanks to @RReverser for fixing my errant observation! With that, this looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #533.