Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Remove implicit "all" group choice. #381

Merged
merged 1 commit into from
Jan 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions highfive/newpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,6 @@ def find_reviewer(self, msg, exclude):
if match:
groups = self.get_groups()
potential = groups.get(match.group(2)) or groups.get("%s/%s" % (match.group(1), match.group(2))) or []
if 'all' in groups:
potential.extend(groups["all"])
picked = self.pick_reviewer(groups, potential, exclude)
if picked:
return picked
Expand Down
2 changes: 1 addition & 1 deletion highfive/tests/fakes.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def get_repo_configs():
}
},
'teams': {
"groups": {"all": [], "a": ["@pnkfelix"], "d": ["@e"], "compiler-team": ["@niko"], "b/c": ["@nrc"]}
"groups": {"all": ["@ehuss"], "a": ["@pnkfelix"], "d": ["@e"], "compiler-team": ["@niko"], "b/c": ["@nrc"]}
}
}

Expand Down