Skip to content

Tera groundwork #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2020
Merged

Tera groundwork #805

merged 5 commits into from
Jun 4, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Jun 2, 2020

  • Added the tera and arc-swap dependencies
  • Made page.rs into a module and added templates.rs, which holds the tera templates and all data that is relevant to them
  • Added custom tera filters and functions in templates.rs
  • Added the --reload option for start-web-server that activates template reloading

@Kixiron Kixiron mentioned this pull request Jun 2, 2020
12 tasks
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if the reloading is backed out for now.

@Kixiron
Copy link
Member Author

Kixiron commented Jun 3, 2020

I made it good, the version I had previously tried was broken

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new template reloading sounds great! Once you add a couple of comments you can merge it yourself (unless @jyn514 has other comments!

@Kixiron Kixiron merged commit c869379 into rust-lang:master Jun 4, 2020
@Kixiron Kixiron deleted the tera-1 branch June 4, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants