Skip to content

Add notes for triage meeting 2019-04-25 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions minutes/triage-meeting/2019-04-25.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# 2019-04-25

## Volunteers wanted

- Somebody needed to reduce [#60136](https://github.com/rust-lang/rust/issues/60136)
- Somebody needed to write documentation [#60059](https://github.com/rust-lang/rust/issues/60059)

## Backport decisions

- "Temporarily accept [i|u][32|size] suffixes on a tuple index and warn" [#60186](https://github.com/rust-lang/rust/issues/60186)
- [Accepted](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/weekly.20meeting.202019-04-25.20.2354818/near/164176203)

- "Revert "compile crates under test w/ -Zemit-stack-sizes" [#59911](https://github.com/rust-lang/rust/issues/59911)
- [Accepted](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/weekly.20meeting.202019-04-25.20.2354818/near/164176203)

## Working group sync

### [wg-rfc-2229](https://github.com/rust-lang/compiler-team/blob/master/working-groups/rfc-2229/README.md)

- RFC 2229 is a proposal to change how closures capture variables.
Instead of capturing the complete variable when a part of it is used (ie `foo.bar`), only the "path" will be captured by the closure.

- This requires a large amount of refactoring in the compiler.

- There is currently a PR open which implements part of this but it regresses compiler error messages in some situtations.

- There's been ongoing discussion as to next steps and other refactorings some of which have issues with light mentoring steps available.

- [Link to full discussion](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/weekly.20meeting.202019-04-25.20.2354818/near/164176279)

### [wg-self-profile](https://github.com/rust-lang/compiler-team/blob/master/working-groups/self-profile/README.md)

- wg-self-profile has been making progress toward the "minimum viable product" tracking issue [#58967](https://github.com/rust-lang/rust/issues/58967):
- A crate called measureme has been created which handles serializing and deserializing profiler events to a compact binary format.
- The crate has been integrated with the existing self-profile infrastructure in rustc.
- There are now summarization and flamegraph tools for processing the profiler data in the repo as well.

- The next step is to work on integrating the summarization tool with perf.rlo.

- [Link to full discussion](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/weekly.20meeting.202019-04-25.20.2354818/near/164177123)