bump git2 dependencies #7706
bump git2 dependencies #7706
Conversation
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Ci seems unhappy. |
crates/cargo-test-support/src/git.rs
Outdated
| @@ -197,7 +197,7 @@ pub fn add_submodule<'a>( | |||
| default_repo_cfg(&subrepo); | |||
| t!(subrepo.remote_add_fetch("origin", "refs/heads/*:refs/heads/*")); | |||
| let mut origin = t!(subrepo.find_remote("origin")); | |||
| t!(origin.fetch(&[], None, None)); | |||
| t!(origin.fetch(&[&String::new()], None, None)); | |||
There was a problem hiding this comment.
Can you explain why this change is needed? The docs still say an empty array is OK.
There was a problem hiding this comment.
Oh, I see, it is due to rust-lang/git2-rs#482. Perhaps it could use a cast instead?
There was a problem hiding this comment.
Yes I believe this is the cause of the broken CI as well, and agree that this should use an explicit cast and/or type parameter to convince the build it should work.
There was a problem hiding this comment.
Yeah looks like I broke the tests by having none-empty vectors, silly me...
Using &Vec::<String>::new() instead of &[&String::new()] seems to work.
matthiaskrgr
force-pushed
the
bump_git
branch
from
d3c837d to
8245e02
Compare
|
Ci is green so: |
|
📌 Commit 8245e02 has been approved by |
bors
added
S-waiting-on-bors
bump git2 dependencies This required some manual code changes which dependabot could not perform.
| @@ -1201,7 +1201,7 @@ fn dep_with_changed_submodule() { | |||
| .remote_set_url("origin", &git_project3.url().to_string()) | |||
| .unwrap(); | |||
| let mut origin = subrepo.find_remote("origin").unwrap(); | |||
| origin.fetch(&[], None, None).unwrap(); | |||
| origin.fetch(&Vec::<String>::new(), None, None).unwrap(); | |||
There was a problem hiding this comment.
| origin.fetch(&Vec::<String>::new(), None, None).unwrap(); | |
| origin.fetch(&[] as &[&str], None, None).unwrap(); |
| @@ -197,7 +197,7 @@ pub fn add_submodule<'a>( | |||
| default_repo_cfg(&subrepo); | |||
| t!(subrepo.remote_add_fetch("origin", "refs/heads/*:refs/heads/*")); | |||
| let mut origin = t!(subrepo.find_remote("origin")); | |||
| t!(origin.fetch(&[], None, None)); | |||
| t!(origin.fetch(&Vec::<String>::new(), None, None)); | |||
There was a problem hiding this comment.
| t!(origin.fetch(&Vec::<String>::new(), None, None)); | |
| t!(origin.fetch(&[] as &[&str], None, None)); |
|
☀️ Test successful - checks-azure |
This required some manual code changes which dependabot could not perform.