Skip to content

[beta-1.87] fix(rustc): Don't panic on unknown bins #15500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

weihanglo
Copy link
Member

Beta backports

In order to make CI pass, the following PRs are also cherry-picked:

### What does this PR try to resolve?

Fixes rust-lang#15493

### How should we test and review this PR?
This takes the most surgical, direct route to addressing the problem.
Alternatively, we could look into why `cargo rustc` and `cargo check`
are different.

### Additional information
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.87.0. Please double check that you specified the right target!

The doctest-xcompile flags have changed,
though we don't want to bother beta toolchain for that.

See rust-lang#15455
@weihanglo weihanglo force-pushed the beta-backport-1.87 branch from ea88f7c to 02b87a7 Compare May 6, 2025 23:51
@epage epage merged commit 99624be into rust-lang:rust-1.87.0 May 7, 2025
21 checks passed
@weihanglo weihanglo deleted the beta-backport-1.87 branch May 7, 2025 00:53
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
…nglo

[beta-1.87] Update cargo

1 commits in 202515849e943032d8fdd3eba57bf2c86e0da736..99624be96e9d213b0e9b1e36451271f24e4a41d8
2025-04-06 19:30:58 -0400 to 2025-05-06 19:28:33 -0500
- [beta-1.87] fix(rustc): Don't panic on unknown bins (rust-lang/cargo#15500)
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
…nglo

[beta-1.87] Update cargo

1 commits in 202515849e943032d8fdd3eba57bf2c86e0da736..99624be96e9d213b0e9b1e36451271f24e4a41d8
2025-04-06 19:30:58 -0400 to 2025-05-06 19:28:33 -0500
- [beta-1.87] fix(rustc): Don't panic on unknown bins (rust-lang/cargo#15500)
@rustbot rustbot added this to the 1.87.0 milestone May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants