Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

remove build dependency on arm-none-eabi-gcc #20

Merged
merged 3 commits into from
Aug 27, 2018
Merged

remove build dependency on arm-none-eabi-gcc #20

merged 3 commits into from
Aug 27, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 26, 2018

by shipping pre-assembled object files. This is the same approach as the one
used in rust-embedded/cortex-m#95

r? @rust-embedded/cortex-m (anyone)

by shipping pre-assembled object files. This is the same approach as the one
used in rust-embedded/cortex-m#95
@japaric japaric requested a review from a team as a code owner August 26, 2018 21:31
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are now shipping 4 different target binaries, should the CI be updated to test all 4 targets? Specifically adding thumbv7em-none-eabi and thumbv7em-none-eabihf.

@japaric
Copy link
Member Author

japaric commented Aug 27, 2018

@adamgreig latest commit tests the other two targets

@adamgreig
Copy link
Member

thanks, lgtm!

bors r+

bors bot added a commit that referenced this pull request Aug 27, 2018
20: remove build dependency on arm-none-eabi-gcc r=adamgreig a=japaric

by shipping pre-assembled object files. This is the same approach as the one
used in rust-embedded/cortex-m#95

r? @rust-embedded/cortex-m (anyone)

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Aug 27, 2018

Build succeeded

@bors bors bot merged commit e4d90c1 into master Aug 27, 2018
@bors bors bot deleted the no-gcc branch August 27, 2018 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants