Fix US backslash #46
Merged
Fix US backslash #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all placed according to their UK layout location, because we map scancode to KeyCode before considering the keyboard layout. Previously I referred to different layouts for ANSI104 and ISO105 and this introduced some errors. Closes #45
jamesmunns
approved these changes
Sep 13, 2024
jannic
approved these changes
Sep 13, 2024
|
If you have a better way of symbolically labelling keycaps without referring to what is written on top of them, I'm all ears! I guess the other option is to refactor pc-keyboard so that scancode mapping is done on a per-layout basis; I'm not just not sure it's worth the effort or the potential increase in code size when multiple layouts are used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I incorrectly marked the "backslash" key on the ANSI 101/104 layout as OEM 7 instead of OEM 5. This is because the virtual key names on https://kbdlayout.info change depending on whether you are looking at a UK layout or a US layout. As we map from scancode to
enum KeyCodebefore looking at which layout it is, we have to standardise on the 'UK' mappings.