Skip to content

Revert "add expect_macro" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Revert "add expect_macro" #4

merged 1 commit into from
Feb 8, 2018

Conversation

vitiral
Copy link
Contributor

@vitiral vitiral commented Feb 8, 2018

This reverts commit bc293ec.

Okay, let's see if we can do this right this time... 😄

@vitiral vitiral requested a review from killercup February 8, 2018 16:54
@vitiral vitiral mentioned this pull request Feb 8, 2018
Copy link

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts commit bc293ec.
@vitiral
Copy link
Contributor Author

vitiral commented Feb 8, 2018

Okay so NOW I specify:

bors r= @killercup

bors bot added a commit that referenced this pull request Feb 8, 2018
4: Revert "add expect_macro" r=killercup a=vitiral

This reverts commit bc293ec.

Okay, let's see if we can do this right this time... 😄
@vitiral
Copy link
Contributor Author

vitiral commented Feb 8, 2018

did I do it right this time? 😆

@killercup
Copy link

Yes! 🎉

(I could've also written bors r+ myself but only people you specified in your bors config are allowed to do that)

@vitiral
Copy link
Contributor Author

vitiral commented Feb 8, 2018

you should be able to approve things. I set bors to allow anyone from the repo editors group (and nobody is specified in the bors config)

@bors
Copy link

bors bot commented Feb 8, 2018

@bors bors bot merged commit 31a59b3 into master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants