Skip to content

add go mod #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

add go mod #3

wants to merge 3 commits into from

Conversation

kayslay
Copy link

@kayslay kayslay commented Nov 5, 2018

add go mod file after facing a bug in go v1.11

@rpip
Copy link
Owner

rpip commented Nov 5, 2018

thanks @kayslay. Could you share more on the bug in go v1.11 that prompted this fix?

@kayslay
Copy link
Author

kayslay commented Nov 6, 2018

when installing/updating the package returns
$ go get -u

...
# github.com/rpip/paystack-go
../../../../pkg/mod/github.com/rpip/paystack-go@v0.0.0-20180509111153-5333b023a74e/bank.go:3:8: can't find import: "fmt"

since the package failed to install completely, when building it returns this error

../../../../pkg/mod/github.com/rpip/paystack-go@v0.0.0-20180509111153-5333b023a74e/plan_test.go:1:1: expected 'package', found 'EOF'
makefile:2: recipe for target 'run' failed
make: *** [run] Error 1

@rpip
Copy link
Owner

rpip commented Nov 6, 2018

Understood. What's the difference between this PR #3 and the other opened PR #4?

Also, can you update the Travis script to ensure this module support build works? E.g:

script:
  - env GO111MODULE=on go build 
  - env GO111MODULE=on go test

@rpip
Copy link
Owner

rpip commented Nov 7, 2018

hi @kayslay, please help here: what's the difference between this PR #3 and the other opened PR #4?

@kayslay
Copy link
Author

kayslay commented Nov 7, 2018

I made a mistake in PR #3. I was trying to merge from my forked master branch. PR #4 merges from the kayslay:rpip-module-name

@rpip
Copy link
Owner

rpip commented Nov 9, 2018

So this #4 PR is where the fix is? Will review.

Thanks

@rpip
Copy link
Owner

rpip commented Nov 9, 2018

closing this #3 PR now.

@rpip rpip closed this Nov 9, 2018
@kayslay
Copy link
Author

kayslay commented Nov 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants