Fix a bug in graph query function and add regression test #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nnmm merged 1 commit into main from fix_graph_query

Oct 15, 2022

Contributor

nnmm commented Oct 14, 2022

It's an easy mistake to make – in https://github.com/ros2/rcl/blob/rolling/rcl/include/rcl/graph.h, some functions have a no_demangle argument and others have a no_mangle argument. The no_mangle argument should be true, but it was false.


          Fix a bug in graph query function and add regression test

21947cd

nnmm force-pushed the fix_graph_query branch from f3a19af to 21947cd Compare

October 14, 2022 19:27

nnmm requested a review from a team

October 14, 2022 19:53

Contributor

christopherjreid commented Oct 15, 2022

Whoops! :)

esteve approved these changes

View reviewed changes

nnmm merged commit 6954069 into main

delete-merged-branch bot deleted the fix_graph_query branch

October 15, 2022 15:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet