Fix small false-positive for ViewBinding #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently opened #710 about suppressing view binding check. I had to suppress since there was a false positive. I looked into our project more and figured out what was wrong.
This is coming from
developer-menu
module where we have different layout for debug and release versions. In case you want to have different layout in different build-types, you have to separate them. But then you can use them in main source set when accessing. ModuleCheck does not account for this valid (but uncommon) case.This PR fixes the issue in most simplest way with a test case. Let me know if this makes sense. I'm not sure if I missed anything. If you have concerns about the change, I hope the test case will be helpful.