-
Notifications
You must be signed in to change notification settings - Fork 30
Array docstrings #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array docstrings #78
Conversation
Will you remove the unsafe |
I was going to rename them |
@glennsl I ended up removing them instead. |
Ready for review. @glennsl would you have a look at this too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, and most of them are repeated throughout, but I've avoided adding repetitive comments. So if you agree with a remark, it's a good idea to look over the rest for the same issue.
Co-authored-by: Glenn Slotte <glenn@slotte.net>
Thanks for the good feedback @glennsl , I think I covered all of it. I'm going to merge this so we can get closer to a new release. Can rework any remaining issues here later on. |
I've done most of the docstrings, enough to get a new release out at least.