-
Notifications
You must be signed in to change notification settings - Fork 30
add docs for date module #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dkirchhof fantastic work! 👏 Let me know when you want me to take a look at it. |
@zth Ready to go! JS dates are a pain. I'm curious about the temporal api. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, really solid! I have a few comments, but they would be mostly icing on the cake, this is already really great.
Thanks for the quick feedback. I will continue tomorrow ;) |
Thank you for your contributions, it's great! |
Should we mention that all the examples depend on the local time zone? |
That's a good idea for sure, that can be slightly confusing with dates. I guess we'll need to add a "disclaimer" to all examples? |
Changed the docs about epoch, added some more examples and added the disclaimer about results according to the local time zone. |
This is looking great to me. You feel done with it? |
I would say so. Otherwise someone else could open a new PR for improvements?! |
Looking great to me, thank you! |
No description provided.