Skip to content

Rename drawImage overloads #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025
Merged

Rename drawImage overloads #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb4cbda
Rename drawImage overloads
nojaf Apr 26, 2025
161e455
Remove localName parameter
nojaf Apr 26, 2025
aca7383
Update test to include binding change
nojaf Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions src/DOMAPI/CanvasRenderingContext2D.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ external drawImage: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage2: (
external drawImageWithSvg: (
canvasRenderingContext2D,
~image: svgImageElement,
~dx: float,
Expand All @@ -373,7 +373,7 @@ external drawImage2: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage3: (
external drawImageWithVideo: (
canvasRenderingContext2D,
~image: htmlVideoElement,
~dx: float,
Expand All @@ -384,7 +384,7 @@ external drawImage3: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage4: (
external drawImageWithCanvas: (
canvasRenderingContext2D,
~image: htmlCanvasElement,
~dx: float,
Expand All @@ -395,7 +395,7 @@ external drawImage4: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage5: (
external drawImageWithImageBitmap: (
canvasRenderingContext2D,
~image: imageBitmap,
~dx: float,
Expand All @@ -406,7 +406,7 @@ external drawImage5: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage6: (
external drawImageWithOffscreenCanvas: (
canvasRenderingContext2D,
~image: offscreenCanvas,
~dx: float,
Expand All @@ -417,7 +417,7 @@ external drawImage6: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage7: (
external drawImageWithVideoFrame: (
canvasRenderingContext2D,
~image: videoFrame,
~dx: float,
Expand All @@ -428,7 +428,7 @@ external drawImage7: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage8: (
external drawImageWithDimensions: (
canvasRenderingContext2D,
~image: htmlImageElement,
~dx: float,
Expand All @@ -441,7 +441,7 @@ external drawImage8: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage9: (
external drawImageWithSvgDimensions: (
canvasRenderingContext2D,
~image: svgImageElement,
~dx: float,
Expand All @@ -454,7 +454,7 @@ external drawImage9: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage10: (
external drawImageWithVideoDimensions: (
canvasRenderingContext2D,
~image: htmlVideoElement,
~dx: float,
Expand All @@ -467,7 +467,7 @@ external drawImage10: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage11: (
external drawImageWithCanvasDimensions: (
canvasRenderingContext2D,
~image: htmlCanvasElement,
~dx: float,
Expand All @@ -480,7 +480,7 @@ external drawImage11: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage12: (
external drawImageWithImageBitmapDimensions: (
canvasRenderingContext2D,
~image: imageBitmap,
~dx: float,
Expand All @@ -493,7 +493,7 @@ external drawImage12: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage13: (
external drawImageWithOffscreenCanvasDimensions: (
canvasRenderingContext2D,
~image: offscreenCanvas,
~dx: float,
Expand All @@ -506,7 +506,7 @@ external drawImage13: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage14: (
external drawImageWithVideoFrameDimensions: (
canvasRenderingContext2D,
~image: videoFrame,
~dx: float,
Expand All @@ -519,7 +519,7 @@ external drawImage14: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage15: (
external drawImageWithSubRectangle: (
canvasRenderingContext2D,
~image: htmlImageElement,
~sx: float,
Expand All @@ -536,7 +536,7 @@ external drawImage15: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage16: (
external drawImageWithSvgSubRectangle: (
canvasRenderingContext2D,
~image: svgImageElement,
~sx: float,
Expand All @@ -553,7 +553,7 @@ external drawImage16: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage17: (
external drawImageWithVideoSubRectangle: (
canvasRenderingContext2D,
~image: htmlVideoElement,
~sx: float,
Expand All @@ -570,7 +570,7 @@ external drawImage17: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage18: (
external drawImageWithCanvasSubRectangle: (
canvasRenderingContext2D,
~image: htmlCanvasElement,
~sx: float,
Expand All @@ -587,7 +587,7 @@ external drawImage18: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage19: (
external drawImageWithImageBitmapSubRectangle: (
canvasRenderingContext2D,
~image: imageBitmap,
~sx: float,
Expand All @@ -604,7 +604,7 @@ external drawImage19: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage20: (
external drawImageWithOffscreenCanvasSubRectangle: (
canvasRenderingContext2D,
~image: offscreenCanvas,
~sx: float,
Expand All @@ -621,7 +621,7 @@ external drawImage20: (
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
*/
@send
external drawImage21: (
external drawImageWithVideoFrameSubRectangle: (
canvasRenderingContext2D,
~image: videoFrame,
~sx: float,
Expand Down
3 changes: 1 addition & 2 deletions src/DOMAPI/Document.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,7 @@ Creates an instance of the element for the specified tag.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/createElement)
*/
@send
external createElement: (document, ~localName: string, ~options: string=?) => element =
"createElement"
external createElement: (document, string, ~options: string=?) => element = "createElement"

/**
Creates an instance of the element for the specified tag.
Expand Down
5 changes: 5 additions & 0 deletions tests/DOMAPI/HTMLCanvasElement__test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions tests/DOMAPI/HTMLCanvasElement__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ switch ctx.fillStyle->FillStyle.decode {
| FillStyle.CanvasGradient(_) => Console.log("CanvasGradient")
| FillStyle.CanvasPattern(_) => Console.log("CanvasPattern")
}

let img: DOMAPI.htmlImageElement = document->Document.createElement("img")->Obj.magic
ctx->CanvasRenderingContext2D.drawImageWithDimensions(~image=img, ~dx=0., ~dy=0., ~dw=200., ~dh=200.)
2 changes: 1 addition & 1 deletion tests/DOMAPI/HTMLInputElement__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
open Global

let input: DOMAPI.htmlInputElement =
document->Document.createElement(~localName="input")->Prelude.unsafeConversation
document->Document.createElement("input")->Prelude.unsafeConversation
let value = input.value
Loading