Expose SimpleQueryRow internals #3
Conversation
Adds a function to expose the DataRowBody of a SimpleQueryRow. Also adds public constructors for OwnedField and DataRowBody, and makes the SimpleQueryRow constructor public. The constructors are useful for integration testing since these structs are all available outside the module.
|
These changes were left out of the last PR because they expose some postgres-protocol internals that might not be appreciated by the upstream maintainers. Exposing the body of the SimpleQueryRow allows us to perform passthrough more efficiently. Without this we would instead read each value from the SimpleQueryRow and re-serialize them ourselves. The public constructors allow us to write serialization unit tests. Without these constructors we would be forced to write cumbersome integration tests. If we make a push to merge our changes upstream, we could consider working without this CL. |
|
generally I would like to avoid getting us in a permanent non-upstreamable situation. Maybe we can ask upstream if they'd be willing to merge something like this? |
|
I would say it doesn't seem promising based on this issue, but I can ask if it would be okay in a feature flag. |
|
Started a discussion here. |
Adds a function to expose the DataRowBody of a SimpleQueryRow. Also adds public constructors for OwnedField and DataRowBody, and makes the SimpleQueryRow constructor public.
The constructors are useful for integration testing since these structs are all available outside the module.