Fix scrolling to top when navigating to links in scrollmode #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make scrolling to locations in lists like footnotes etc the scrollToRect method now places the target element as the topmost element when scrolling. Fixes Navigator places locator with anchor in the middle of the screen in scroll mode readium#328
mickael-menu
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Thank you @chrfalch 👌
Note that this could be weird with highlights, ideally we want to center them. However it looks like an usability issue when jumping to a toc item or a link, as you have to find the destination on the page. So for now let's use this strategy, but come up later with an API solution to send additional options to the go() method to state if we prefer to center the destination vertically or not, and let the app decides on a case-by-case basis.
mickael-menu
force-pushed
the
fix/328-scroll-to-top
branch
from
19c714e to
4f5fbd1
Compare
mickael-menu
force-pushed
the
fix/328-scroll-to-top
branch
from
4f5fbd1 to
1fc2fdb
Compare
mickael-menu
force-pushed
the
fix/328-scroll-to-top
branch
from
78e6c0b to
a01dbc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make scrolling to locations in lists like footnotes etc the scrollToRect method now places the target element as the topmost element when scrolling.
Fixes Navigator places locator with anchor in the middle of the screen in scroll mode #328