Skip to content

Remove containers from deprecated PublicationServer #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kristojorg
Copy link
Contributor

As noted in #322 , stored properties cannot be marked unavailable with @available. Since the PublicationServer is deprecated anyway, and the containers property does appear to be used at all, this PR simply removes it. The only difference for consumers should be that if they are trying to use the deprecated PublicationServer they will no longer see a warning message when trying to access containers, but will see an error that the property doesn't exist.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that's fine, this has been marked as unavailable since 2.0 so I doubt anybody is still using this property and needs the warning.

Thank you for taking a look into that.

@mickael-menu mickael-menu changed the base branch from main to develop July 21, 2023 11:45
@kristojorg kristojorg temporarily deployed to LCP July 21, 2023 11:45 — with GitHub Actions Inactive
@kristojorg kristojorg temporarily deployed to LCP July 21, 2023 11:45 — with GitHub Actions Inactive
@mickael-menu mickael-menu linked an issue Jul 21, 2023 that may be closed by this pull request
@kristojorg kristojorg temporarily deployed to LCP July 21, 2023 12:04 — with GitHub Actions Inactive
@kristojorg kristojorg temporarily deployed to LCP July 21, 2023 12:04 — with GitHub Actions Inactive
@mickael-menu mickael-menu temporarily deployed to LCP July 21, 2023 12:10 — with GitHub Actions Inactive
@mickael-menu mickael-menu temporarily deployed to LCP July 21, 2023 12:10 — with GitHub Actions Inactive
@mickael-menu mickael-menu merged commit 009cb3a into readium:develop Jul 21, 2023
@kristojorg kristojorg deleted the deprecating-publication-server branch July 24, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stored properties cannot be marked unavailable with @available
2 participants