Skip to content

docs: translated Fragments.md #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 25, 2019
Merged

docs: translated Fragments.md #94

merged 12 commits into from
Sep 25, 2019

Conversation

RickyWooo
Copy link
Contributor

Follow the existing translation pattern and translate Fragments.md, feel free to let me know if there is any problem, thank you.

@netlify
Copy link

netlify bot commented Sep 14, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 25c9b92

https://deploy-preview-94--zh-hant-reactjs-org.netlify.com

Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution. 👍
Would you mind to add space between the English and Chinese? 🙏

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RickyWooo
Copy link
Contributor Author

RickyWooo commented Sep 16, 2019

Thanks @bugtender & @neighborhood999 for both of your helps, I will review it carefully and create PR again.

@RickyWooo RickyWooo closed this Sep 16, 2019
@neighborhood999
Copy link
Member

Hi @RickyWooo, you don't need to close this PR, just edit and push it.

@RickyWooo RickyWooo reopened this Sep 17, 2019
@RickyWooo
Copy link
Contributor Author

@neighborhood999 I see :) it just my working habits 😂, I have modified on the documents for your reference, thank you.

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestions, feel free comment below if have any problem, thanks.

Chong-You, Wu and others added 8 commits September 19, 2019 19:17
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@RickyWooo
Copy link
Contributor Author

RickyWooo commented Sep 20, 2019

Thanks for @neighborhood999's efforts, I have pushed the latest translation :)

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RickyWooo, the code block comments need to be translated in the line 125, others LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants