-
Notifications
You must be signed in to change notification settings - Fork 88
docs: translated Fragments.md #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for zh-hant-reactjs-org ready! Built with commit 25c9b92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your contribution. 👍
Would you mind to add space between the English and Chinese? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above @bugtender mention, you can follow this guide:
Thanks @bugtender & @neighborhood999 for both of your helps, I will review it carefully and create PR again. |
Hi @RickyWooo, you don't need to close this PR, just edit and push it. |
@neighborhood999 I see :) it just my working habits 😂, I have modified on the documents for your reference, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some suggestions, feel free comment below if have any problem, thanks.
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Thanks for @neighborhood999's efforts, I have pushed the latest translation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RickyWooo, the code block comments need to be translated in the line 125, others LGTM.
Follow the existing translation pattern and translate Fragments.md, feel free to let me know if there is any problem, thank you.