Skip to content

docs: synthetic-event branch #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jul 27, 2019
Merged

docs: synthetic-event branch #81

merged 32 commits into from
Jul 27, 2019

Conversation

chloewlin
Copy link
Member

@chloewlin chloewlin commented Jul 7, 2019 •
edited
Loading

7/6 Set up synthetic-event branch
7/6 This PR is ready for review

  • Overview
  • Event Pooling
  • Supported Events
  • Reference

@tesseralis tesseralis mentioned this pull request Jul 7, 2019
Closed
92 tasks
@netlify
Copy link

netlify bot commented Jul 7, 2019 •
edited
Loading

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 92bc2aa

https://deploy-preview-81--zh-hant-reactjs-org.netlify.com

@chloewlin chloewlin changed the title Set up synthetic-event branch docs: synthetic-event branch Jul 7, 2019
bugtender
bugtender reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! and sorry for late reviewing. 😅

neighborhood999
neighborhood999 reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Reference section, I prefer to keep event name to the original term. If have any problem, feel free discuss in the under.

chloewlin and others added 12 commits July 26, 2019 23:25
@chloewlin @neighborhood999
Update content/docs/reference-events.md
49b12b1 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
a7fd457 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
a25b6e9 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
8e1aa3b 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
8801372 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
3c5dfc3 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
93662fc 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
54e53d3 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
35c579e 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
699eda6 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
4f1c8a9 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
f8246f7 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
chloewlin and others added 16 commits July 26, 2019 23:29
@chloewlin @neighborhood999
Update content/docs/reference-events.md
7850917 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
940ca14 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
367f9f4 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
75c0622 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
b538bf3 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
19f0580 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
5e8088a 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
727225b 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
1a93623 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
82fc675 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
bde800d 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
e261e5a 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
a9484c2 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin @neighborhood999
Update content/docs/reference-events.md
bd599ed 
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin
Apply suggested changes
98adde1
@chloewlin
Merge branch 'synthetic-event' of https://github.com/chloewlin/zh-han…
92bc2aa 
…t.reactjs.org into synthetic-event
@chloewlin
Copy link
Member Author

Thank you, @bugtender and @neighborhood999, for your careful and thorough reviews. I've updated everything you suggested and will merge this in soon.

@chloewlin chloewlin merged commit 478ae54 into reactjs:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugtender bugtender bugtender left review comments

@neighborhood999 neighborhood999 neighborhood999 left review comments

Assignees
No one assigned
Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chloewlin @bugtender @neighborhood999