Skip to content

Getting started #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 4, 2019
Merged

Getting started #43

merged 19 commits into from
Mar 4, 2019

Conversation

kevinch
Copy link
Contributor

@kevinch kevinch commented Feb 15, 2019

@tdd voici ta trad de la page getting-started.

Plusieurs points:

  • online playground traduit en terrain de jeu en ligne

Non traduit:

  • Hello world: "Essayez um modèle Hello World sur CodePen"
  • widgets: "étendre progressivement sa présence ou la limiter à quelques widgets dynamiques"

Tiens moi au jus.

@kevinch kevinch mentioned this pull request Feb 15, 2019
Closed
@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 15, 2019
@lbelavoir
Copy link
Contributor

Il serait judicieux d'ajouter les traductions choisies pour online playground et widget dans le glossaire pour garder une unité au sein de la doc comme ce sont deux termes assez délicats à traduire.

@tdd
Copy link
Collaborator

tdd commented Feb 15, 2019

Certes, mais je te dirai ça quand j'aurai fait la revue et ancré les trads 😉

sheplu
sheplu requested changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques retour sur la traduction.
De petites erreurs, et deux trois endroit ou j'ai propose une traduction alternative qui me semblait mieux

@kevinch
Copy link
Contributor Author

kevinch commented Feb 18, 2019

@sheplu mis à jour! Thx @laruiss pour la review.

JeremiePat
JeremiePat requested changes Feb 24, 2019
View reviewed changes
Copy link
Collaborator

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut :) J'ai fait une nouvelle passe de suggestions (si tu est ok avec tu as juste à les accepter pour que ça fasse directement les commits qui vont bien sur ta branche).

Ce serait cool aussi si tu pouvais rebase ta branche sur master pour résoudre les conflits lié au màj de reactjs.org ;)

@JeremiePat JeremiePat added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Feb 24, 2019
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for fr-reactjs ready!

Built with commit f276d9f

https://deploy-preview-43--fr-reactjs.netlify.com

kevinch and others added 16 commits February 25, 2019 15:11
@kevinch
Traductions L10N
137c36d
@kevinch
Translate mdn links
7f660b1
@kevinch
Update typography
e1b1608
@kevinch
Update L10N
47417f9
@kevinch
Fix typos & update L10N
7e22e83
@JeremiePat @kevinch
Update content/docs/getting-started.md
4d0ce3b 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
9751d63 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
2ddc4c4 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
9309b90 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
ca5d831 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
a1c0df5 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
f02c533 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
8948731 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
ea87130 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
d2b5cd2 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@JeremiePat @kevinch
Update content/docs/getting-started.md
cf0dc7f 
Co-Authored-By: kevinch <kevinch@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for fr-reactjs ready!

Built with commit cbe807a

https://deploy-preview-43--fr-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for fr-reactjs ready!

Built with commit ce24972

https://deploy-preview-43--fr-reactjs.netlify.com

@kevinch
Copy link
Contributor Author

kevinch commented Feb 25, 2019

@JeremiePat, mis à jour. Merci pour les suggestions!

@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 27, 2019
@kevinch
Copy link
Contributor Author

kevinch commented Mar 1, 2019

@tdd fyi, je vais être afk durant 4 semaines sans accès web donc si il y a encore des modifs a faire hesites pas a faire un commit sur la branche. A tte!

@tdd tdd removed the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 4, 2019
@tdd tdd merged commit fb143c8 into reactjs:master Mar 4, 2019
@tdd
Copy link
Collaborator

tdd commented Mar 29, 2019

@kevinch souhaites-tu qu'on utilise ton vrai nom pour les remerciements de trad ? Auquel cas quel est-il ?

@kevinch
Copy link
Contributor Author

kevinch commented Apr 1, 2019

@tdd kevin chevallier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laruiss laruiss laruiss left review comments

@JeremiePat JeremiePat JeremiePat requested changes

@sheplu sheplu sheplu requested changes

Assignees
No one assigned
Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevinch @lbelavoir @tdd @JeremiePat @sheplu @laruiss