Skip to content

Add simple tests & update dev dependencies #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Oct 14, 2021

Summary

it first PR from series of PRs that will cover all code

  • Update test environment
  • Update exists test
  • Add new tests
  • Make CI green

Test Plan

yarn
yarn test

What's required for testing (prerequisites)?

need to install new dependencies

What are the steps to reproduce (after prerequisites)?

no

Compatibility

OS Implemented
iOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

To fix error: @testing-library/react-hooks@7.0.2: The engine "node" is incompatible with this module. Expected version ">=12". Got "10.24.1"
```
npm pack --dry-run # to test
```
@LinusU LinusU added the skip-release Preserve the current version when merged label Oct 16, 2021
@LinusU LinusU merged commit 9331f90 into react-native-community:master Oct 16, 2021
@pvinis
Copy link
Member

pvinis commented Oct 18, 2021

🚀 PR was released in v2.7.0 🚀

@pvinis pvinis added the released This issue/pull request has been released. label Oct 18, 2021
@retyui retyui deleted the update-tests branch October 18, 2021 15:10
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants