Skip to content

Deprecated API #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
retyui opened this issue Oct 18, 2021 · 6 comments · Fixed by #412
Closed

Deprecated API #267

retyui opened this issue Oct 18, 2021 · 6 comments · Fixed by #412

Comments

@retyui
Copy link
Contributor

retyui commented Oct 18, 2021

Do you have any ideas on how to support the next hooks as they are deprecated or removed?

Shell we will mark them as @deprecated too (using comments), or add info in the README file?

useCameraRoll

CameraRoll was removed in React Native 0.61.x

image

useClipboard

Clipboard marker as deprecated, but not deleted yet (see master)

image
@LinusU
Copy link
Member

LinusU commented Oct 19, 2021

Yeah, this is interesting. Potentially the best way is to try and contribute the hooks upstream, to the new repositories! Then we would also deprecate them in this repository...

@retyui
Copy link
Contributor Author

retyui commented Oct 20, 2021 •
edited
Loading

So, I can create PR to cameraroll repo, and when it will be accepted we can "deprecate them in this repository"

@LinusU
Copy link
Member

LinusU commented Oct 20, 2021

So, I can create PR to cameraroll repo, and when it will be accepted we can "deprecate them in this repository"

That would be amazing! ❤️

@retyui retyui mentioned this issue Oct 21, 2021
Merged
4 tasks
@retyui
Copy link
Contributor Author

retyui commented Nov 11, 2022

@LinusU I think now we can deprecated them, PR fro useCameraRoll was merged

@LinusU
Copy link
Member

LinusU commented Nov 11, 2022

Great! Could you submit a PR that adds the deprecation? 🙏

retyui added a commit to retyui/react-native-hooks that referenced this issue Nov 15, 2022
@retyui
Deprecate hooks that use old API (fix: react-native-community#267)
420edf3
@retyui retyui mentioned this issue Nov 15, 2022
Merged
4 tasks
@retyui
Copy link
Contributor Author

retyui commented Nov 15, 2022

@LinusU ready #315

@retyui retyui closed this as completed Nov 15, 2022
retyui added a commit to retyui/react-native-hooks that referenced this issue Nov 15, 2022
@retyui
Deprecate hooks that use old API (fix: react-native-community#267)
2d3b769
LinusU added a commit that referenced this issue Nov 15, 2022
@LinusU
Merge pull request #315 from retyui/fix-267
60d822e 
Deprecate hooks that use old API (fix: #267)
@github-actions github-actions bot mentioned this issue Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version Packages react-native-community/hooks
2 participants
@LinusU @retyui