Skip to content

Fixes 'RNCAsyncStorage/RNCAsyncStorageDelegate.h' file not found #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

harveyconnor
Copy link
Contributor

Summary:

Was receiving a compile error when running react-native run-ios

node_modules/@react-native-community/async-storage/ios/RNCAsyncStorage.h:10:9:
'RNCAsyncStorage/RNCAsyncStorageDelegate.h' file not found

#import <RNCAsyncStorage/RNCAsyncStorageDelegate.h>
            ~~ ~~~~~^~~

A similar fix was required in other libraries, since the file is in the same directory as the header. You can require it without a namespace.

Test Plan:

Run react-native run-ios and if it compiles then it was a success.

@krizzu krizzu added the platform: iOS This is iOS specific label Jun 7, 2019
@krizzu
Copy link
Member

krizzu commented Jun 7, 2019

Thanks!

cc @tido64

@tido64
Copy link
Member

tido64 commented Jun 7, 2019

Thanks :)

Did you try this in a project with modules disabled? I think we added the full path because of it.

@harveyconnor
Copy link
Contributor Author

Nope this was with other modules present.

@tido64
Copy link
Member

tido64 commented Jun 8, 2019

Sorry, I meant Objective-C modules. You can see the setting in Xcode: https://i.stack.imgur.com/PyWgB.png

@tido64
Copy link
Member

tido64 commented Jun 8, 2019

Also, which version of AsyncStorage are you using? This shouldn't be happening in the latest version.

@harveyconnor
Copy link
Contributor Author

Modules was enabled.
And using version 1.4.2

Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I was sure this broke building Objective-C modules disabled earlier. Just did a quick test now and didn't get a break before or after this PR. Since it fixes your scenario, I don't mind getting it checked in.

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harveyconnor @tido64 🎉

@tido64 tido64 merged commit 4e91626 into react-native-async-storage:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: iOS This is iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants