Allow user to signal they're in server process via environment variable #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RailsLiveReload currently relies on the
::Rails::Server
being available to run, I'm assuming this is just a proxy for understanding that you're in a server process and when Rails users start up their server withrails s
this works great.However my team, and I would think many others may be calling
puma
or their other web server directly to start their Rails server.rails s
has a limited set of options, and it doesn't seem to even respect most of the options in the context of puma (port/bind options). For that reason my team callsbundle exec puma
directly and passes it different config files per environment.All that being said this small PR gives users the option to tell
RailsLiveReload
through environment variables that it is indeed in a server process, and thus safe to start up.This may also help solve: #30