Prevent asset_path clashing with route definition in a rails app
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Fish <si@mon.fish>
ollie-nye
force-pushed
the
prevent-asset-path-clashing-with-routes
branch
from
d6c3bc1 to
5f544b5
Compare
gmcgibbon
approved these changes
Feb 11, 2022
|
Yeah, this is technically a breaking change of the expected API, but in practice to me it seems early enough in the library's lifetime that we can reasonably assume currently-extant callers are almost certainly passing a Rails-sourced object that already meets this criteria. We could retain compatibility with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rails/rails#44403
If a route is defined that generates the helper
asset_path, theview_contextpassed toimportmap.to_jsonwill use the resource route instead of the asset pipeline route. By default, this is aliased topath_to_asset, so updating this method to use that instead resolves the issue.