Prefer erlang:monotonic_time/0 for elapsed time measurements
#10928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Apr 8, 2024
This is now the recommended way to measure durations with the time API: <https://www.erlang.org/doc/apps/erts/time_correction#how-to-work-with-the-new-api>
the-mikedavis
force-pushed
the
md/monotonic-elapsed-time
branch
from
c87aecc to
1b35c3f
Compare
|
I reverted the change to switch to milliseconds for the feature flag registry regen since #10988 might reduce the time it takes to generate the registry down to hundreds of microseconds. So now this patch just switches to |
the-mikedavis
added a commit
that referenced
this pull request
Apr 13, 2024
Prefer `erlang:monotonic_time/0` for elapsed time measurements (backport #10928)
ansd
added a commit
that referenced
this pull request
Jun 6, 2024
Monotonic time instead of wall clock time should be used to measure a duration. This is mostly a cosmetic change given that consumer timeouts are 30 mins by default. See also rabbitmq/khepri#239 #10928
ansd
added a commit
that referenced
this pull request
Jun 6, 2024
Monotonic time instead of wall clock time should be used to measure a duration. This is mostly a cosmetic change given that consumer timeouts are 30 mins by default. See also rabbitmq/khepri#239 #10928
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Monotonic time instead of wall clock time should be used to measure a duration. This is mostly a cosmetic change given that consumer timeouts are 30 mins by default. See also rabbitmq/khepri#239 #10928 (cherry picked from commit f5d2fd6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now the recommended way to measure durations with the time API: https://www.erlang.org/doc/apps/erts/time_correction#how-to-work-with-the-new-api. This is mostly a cosmetic change though since it's only used in/for log messages.
\cc @dumbbell I've changed the log message for the time it takes to regen the feature flag registry to be milliseconds instead of microsecond as it takes ~35-40ms for me locally. (Similar to #10674)