Skip to content

Making sure AsyncEventHandlers are all run. Fixes issue #838. #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

Making sure AsyncEventHandlers are all run. Fixes issue #838. #839

merged 1 commit into from
May 20, 2020

Conversation

stebet
Copy link
Contributor

@stebet stebet commented May 19, 2020

Proposed Changes

Fixes #838 by making sure all asynchronous event handlers are run.

Types of Changes

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@lukebakken lukebakken self-assigned this May 20, 2020
@lukebakken lukebakken added this to the 6.1.0 milestone May 20, 2020
lukebakken
lukebakken approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stebet

@lukebakken lukebakken merged commit 9964644 into rabbitmq:master May 20, 2020
@michaelklishin
Copy link
Contributor

@stebet thank you for your ongoing contributions 🥇

@stebet stebet deleted the issue838 branch May 20, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

The implementation of the AsyncEventingBasicConsumer is not safe when there are multiple handlers attached
3 participants
@stebet @michaelklishin @lukebakken