Address ObjectDisposedException
#1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1802
branch
2 times, most recently
from
0f2b643 to
b63e9af
Compare
Fixes #1802 * Start by modifying channel creation program to try and reproduce the issue. * Handle cancellation token edge case (immediately canceled) in connection and channel `CloseAsync` * Better cancellation token handling in `CloseAsync` * Add test to reproduce continuation timeout. * Add code to take note of `OperationCanceledException` exceptions and indicate RPC errors. * Use a queue of `ProtocolCommandId` values to keep track of RPC commands that have timed out. Co-authored-by: Paulo Morgado <470455+paulomorgado@users.noreply.github.com>
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1802
branch
from
b63e9af to
9a8d57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address
ObjectDisposedExceptionFixes #1802