Skip to content

Fix #1777 #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix #1777 #1781

merged 1 commit into from
Feb 12, 2025

Conversation

lukebakken
Copy link
Collaborator

Fixes #1777

  • Adds a test that requires PossibleAuthenticationFailureException when attempting to log into RabbitMQ using invalid credentials.
  • Fix the issue by calling ClosedViaPeerAsync after sending the connection.close-ok response to the broker.

@lukebakken
Fix #1777
e33544d 
Fixes #1777

* Adds a test that requires `PossibleAuthenticationFailureException` when attempting to log into RabbitMQ using invalid credentials.
* Fix the issue by calling `ClosedViaPeerAsync` _after_ sending the `connection.close-ok` response to the broker.
@lukebakken lukebakken added this to the 7.1.0 milestone Feb 12, 2025
@lukebakken
Copy link
Collaborator Author

@plewam - if you have the ability to test this PR in your environment, that would be great! Otherwise, I should have an official alpha release available via NuGet soon.

@lukebakken lukebakken self-assigned this Feb 12, 2025
@lukebakken lukebakken marked this pull request as ready for review February 12, 2025 22:31
@lukebakken lukebakken merged commit 0f2f247 into main Feb 12, 2025
16 checks passed
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1777 branch February 12, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Throw exception during CreateConnectionAsync in case of wrong credentials
1 participant
@lukebakken