-
Notifications
You must be signed in to change notification settings - Fork 605
Make channel events async #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI I noticed that the Consumer events do not follow the newly introduced naming convention that @lukebakken started introducing in #1677 (comment) I would suggest doing another follow-up PR to keep the changes easily reviewable. |
13f0186
to
76abfd2
Compare
Cool green. Maybe you can merge all together and we can drop the base PR |
cdc2617
to
48e6307
Compare
@lukebakken I think this is good to go. Then I can start working on the EventArgs change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed Changes
Important
Based on #1679. Should be rebased after merge of #1679
Follow through on discussion in #1675 (comment)
@lukebakken mentioned his original intent was to make the events async across the board but stopped.
This PR would align the channel API surface
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.