Merge pull request #1141 from rabbitmq/lukebakken/fix-appveyor #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix and update AppVeyor build (cherry picked from commit 4628927)
lukebakken
commented
Feb 15, 2022
| @@ -72,6 +73,7 @@ internal DecimalData(uint flags, uint hi, uint lo, uint mid) | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
| public static decimal ReadDecimal(ReadOnlySpan<byte> span) | |||
| { | |||
| byte scale = span[0]; | |||
There was a problem hiding this comment.
@michaelklishin @stebet it's very strange that I had to manually fix this spot and below. These changes were introduced in this PR: #984
Is this indicative of other potential problems on the 7.x branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and update AppVeyor build
(cherry picked from commit 4628927)
See also:
#1141
#1143