ExchangeBind problem impacts more versions than initial testing revealed

[bording]

So it looks like the problem I found in #314 is more widespread than my initial testing led me to believe.

In the master branch, AutomaticRecoveryEnabled is true by default, and I forgot to manually set that to true when testing. 😦

Revised repro:

var factory = new ConnectionFactory();
factory.AutomaticRecoveryEnabled = true;

var connection = factory.CreateConnection();
var channel = connection.CreateModel();

channel.ExchangeDeclare("test1", ExchangeType.Fanout);
channel.ExchangeDeclare("test2", ExchangeType.Fanout);

channel.ExchangeBind("test1", "test2", "");
channel.ExchangeBind("test1", "test2", ""); //this throws

Here is the result of my testing:

3.6.6: works
3.6.7: broken
3.6.8: broken

4.1.1: works
4.1.2: broken

5.0.0-pre3: broken
5.0.0-pre4: works

So this bug is currently still a problem for 3.6.7, 3.6.8, and 4.1.2.

[kjnilsson]

Thanks for finding this. . I will cherrypick the fix into stable and 4.x.

…

On Tue, 28 Mar 2017 at 00:38, Brandon Ording ***@***.***> wrote: So it looks like the problem I found in #314 <#314> is more widespread than my initial testing led me to believe. In the master branch, AutomaticRecoveryEnabled is true by default, and my repro forgot to manually set that to true. Revised repro: var factory = new ConnectionFactory();factory.AutomaticRecoveryEnabled = true; var connection = factory.CreateConnection();var channel = connection.CreateModel(); channel.ExchangeDeclare("test1", ExchangeType.Fanout);channel.ExchangeDeclare("test2", ExchangeType.Fanout); channel.ExchangeBind("test1", "test2", "");channel.ExchangeBind("test1", "test2", ""); //this throws Here is the result of my testing: 3.6.6: works 3.6.7: broken 3.6.8: broken 4.1.1: works 4.1.2: broken 5.0.0-pre3: broken 5.0.0-pre4: works So this bug is currently still a problem for 3.6.7, 3.6.8, and 4.1.2. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#317>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIDlK42J0wnlgfA8TAh9dnFDA3NbzBWks5rqEhhgaJpZM4Mq9cF> .

[michaelklishin]

We should release a 4.1.3 then.

[adamralph]

And a 3.6.9?

[michaelklishin]

oh, and perhaps cherry-pick to 3.6.x

[kjnilsson]

Working on it.

[kjnilsson]

4.1.3 is up: https://www.nuget.org/packages/RabbitMQ.Client/4.1.3

[adamralph]

Thanks @kjnilsson - I'll smoke test it.

[adamralph]

@kjnilsson I'm happy to report that 4.1.3 seems OK, with respect to NServiceBus.RabbitMQ.

I'll keep an eye out for 3.6.9.

[adamralph]

@michaelklishin @kjnilsson I'm happy to report that 3.6.9 seems OK, with respect to NServiceBus.RabbitMQ.

[kjnilsson]

@adamralph good to hear. Thanks for reporting back.