Enable tests #669
Merged
Enable tests #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Dec 4, 2020
| pc <- lapply(get_source_expressions(f)[["expressions"]], `[[`, "parsed_content") | ||
| eval(substitute(code)) | ||
| content_env <- new.env() | ||
| content_env$pc <- lapply(get_source_expressions(f)[["expressions"]], `[[`, "parsed_content") |
There was a problem hiding this comment.
this is because pc was seen as an "unused variable"
MichaelChirico
commented
Dec 4, 2020
| @@ -88,7 +88,7 @@ test_that("lint() results do not depend on the position of the .lintr", { | |||
| ) | |||
| ) | |||
|
|
|||
| lints_with_config_in_source_dir <- withr::with_dir( | |||
| lints_with_config_in_r_dir <- withr::with_dir( | |||
There was a problem hiding this comment.
long variable name
MichaelChirico
commented
Dec 4, 2020
|
|
||
| # Template packages for use in testing are stored in | ||
| # `tests/testthat/dummy_packages/<pkgName>` | ||
| # tests/testthat/dummy_packages/<pkgName> |
There was a problem hiding this comment.
these were all dinged by commented_code_linter
AshesITR
reviewed
Dec 4, 2020
| # When called from inside a package: | ||
| # lint_package(".") | ||
| # lint_package(".") # nolint |
There was a problem hiding this comment.
Might be a good idea to # nolint this according to the new #660 syntax once we settle on a final default.
There was a problem hiding this comment.
how about a follow-up issue for tagging all # nolints in the package that way?
./R/closed_curly_linter.R: message = "Closing curly-braces should always be on their own line, unless it's followed by an else.", # nolint
./R/function_left_parentheses.R:function_left_parentheses_linter <- function(source_file) { # nolint: function_left_parentheses_linter.
./R/get_source_expressions.R: })(prev_locs == lag(next_locs)) # nolint
./R/open_curly_linter.R: message = "Opening curly braces should never go on their own line and should always be followed by a new line.", # nolint
./R/lint.R: expr_lints <- flatten_lints(linters[[linter]](expr)) # nolint
./tests/testthat/test-deprecated.R: expect_quiet_lint("'/blah/file.txt'", # nolint
./tests/testthat/test-lint_package.R:# lint_package(".") # nolint
./tests/testthat/test-lint_package.R:# lint_package(path_to_package) # nolint
./tests/testthat/test-rstudio_markers.R: expect_equal(marker3$basePath, "test") # nolint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #668