Fix some regex-based linters getting spurious matches #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests added to ensure paren-brace linter, equals-NA linter and no-tab linter do not flag lints in irrelevant sections of code (eg, strings / comments).
This can check if a regex-match is covered by an expression in a source_file and restrict analysis to tokens of a particular type, if required.
Also, rename file containing equals_na_linter to match format of other linter-files (`*_linter.R` not `*_lintr.R`)
…ntr into regex-based-linter-issue-441
MichaelChirico
force-pushed
the
regex-based-linter-issue-441
branch
from
2e5a03d to
2cc47ec
Compare
|
For now I'll leave this as is on the assumption that #546 would be merged first. After that, I would keep the tests for |
MichaelChirico
changed the title
|
The same issue as #546 (about the XML tree being missing when there's a syntax error) was hitting |
…intr into regex-based-linter-issue-441
This was referenced Nov 30, 2020
AshesITR
previously approved these changes
Nov 30, 2020
AshesITR
previously approved these changes
Nov 30, 2020
AshesITR
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #441
Forked from #467 -- re-filing with the base branch on the main repo (cc @russHyde)