enable open_curly_linter in .lintr

[MichaelChirico]

Closes #596

There are already no lints for this linter, we just need to enable it in the options:

lintr::lint_package(linters = lintr::open_curly_linter)
# returns nothing

[AshesITR]

This is already part of the default linters, no need to manually add it.

[lintr-bot]

R/expect_lint.R:54:28: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​  lint_str <- if (n_lints) {paste0(c("", lints), collapse="\n")} else {""}
                           ^

R/expect_lint.R:54:71: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​  lint_str <- if (n_lints) {paste0(c("", lints), collapse="\n")} else {""}
                                                                      ^

R/get_source_expressions.R:46:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​    {
    ^

R/get_source_expressions.R:319:44: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​  tab_cols <- lapply(tab_cols, function(x) {if (x[[1L]] < 0L) {NA} else {x}})
                                           ^

R/get_source_expressions.R:319:63: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​  tab_cols <- lapply(tab_cols, function(x) {if (x[[1L]] < 0L) {NA} else {x}})
                                                              ^

R/get_source_expressions.R:319:73: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​  tab_cols <- lapply(tab_cols, function(x) {if (x[[1L]] < 0L) {NA} else {x}})
                                                                        ^

R/spaces_inside_linter.R:43:72: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​                column_number = if (substr(line, start, start) == " ") {start} else {start + 1L},
                                                                       ^

R/spaces_inside_linter.R:43:85: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​                column_number = if (substr(line, start, start) == " ") {start} else {start + 1L},
                                                                                    ^

R/unneeded_concatenation_linter.R:24:35: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​          message = if (num_args) {msg_const} else {msg_empty},
                                  ^

R/unneeded_concatenation_linter.R:24:52: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​          message = if (num_args) {msg_const} else {msg_empty},
                                                   ^

[MichaelChirico]

Hmm, the linter bot seems to have found lints that the command in the issue did not:

lintr::lint_package(linters = lintr::open_curly_linter)

This also didn't detect those lints that the bot found:

setwd('R'); for (f in list.files()) print(lintr::lint(f, lintr::open_curly_linter))

The lints look correct though, any idea?

[MichaelChirico]

Well, I can reproduce locally with this at least:

Rscript -e "lintr::lint_package('.')"

with the new settings. I'll edit the issue descriptions...

[lintr-bot]

R/get_source_expressions.R:318:44: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​  tab_cols <- lapply(tab_cols, function(x) {if (x[[1L]] < 0L) NA else x})
                                           ^