Skip to content

Adds RStudio addins #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2017
Merged

Adds RStudio addins #264

merged 4 commits into from
Nov 2, 2017

Conversation

JhossePaul
Copy link
Contributor

This commit adds two addins to RStudio to bind shortcuts for easier usage. Now you can, for example, bind
Alt+Shift+L and lint the current source code.

@codecov-io
Copy link

codecov-io commented Sep 5, 2017

Codecov Report

Merging #264 into master will decrease coverage by 0.7%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   86.12%   85.41%   -0.71%     
==========================================
  Files          39       40       +1     
  Lines        2183     2201      +18     
==========================================
  Hits         1880     1880              
- Misses        303      321      +18
Impacted Files Coverage Δ
R/addins.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5431140...1d82d00. Read the comment docs.

R/addins.R Outdated
}

addin_lint_package <- function () {
lintr::lint_package()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably would be safer to retrieve the project directory (rstudioapi::getActiveProject()) and pass that to lint_package()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Indeed I was thinking I completely forgot defensive programming. I'll add this and some more checks and then update the pull request

@jimhester
Copy link
Member

Thanks this is a good idea! I made a minor comment, could you also add a note to NEWS.md with this change and mentioning your GitHub handle and this PR number?

Thanks!

@jimhester
Copy link
Member

Great thanks!

@jimhester jimhester merged commit 08d66cd into r-lib:master Nov 2, 2017
@russHyde russHyde mentioned this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants